Expose more loopback middleware for require#834
Conversation
There was a problem hiding this comment.
This is IMHO rather silly. errorHandler is just an alias for require('errorhandler'). In your middleware.json, you can use errorhandler instead of loopback/error-handler.
There was a problem hiding this comment.
I'm fine to remove error-handler.
|
IMO this is the last pull request related to middleware that we need to land before we can release a new minor version. To speed things up, I am proposing the following:
@ritch do you have any opinion on this PR? |
|
@bajtos, I'll make the changes based on your proposal. It won't conflict with the discussion at strongloop/loopback-boot#70. |
5ea4ada to
e56ec57
Compare
|
Done. |
There was a problem hiding this comment.
Is there any reason for pinning down the minor version via ~, instead of supporting all minor versions via ^?
|
One more comment, feel free to land the PR if you have convincing reasons why |
|
I'll merge the PR and fix the dependency conventions in a different one. |
e56ec57 to
a9b4df1
Compare
…eware Expose more loopback middleware for require
3 participants
/to @bajtos
We need a way to reference loopback.favicon and other middleware from middleware.json.